chore: remove inline styling & use clsx consistently#331
Merged
Conversation
zlataovce
reviewed
Mar 30, 2024
MiniDigger
reviewed
Mar 30, 2024
Contributor
Author
|
A |
Contributor
Author
|
The internal styles added to the slider markers has been replaced with flexbox styling. It's now more accurate than how it was before. Any leftover internal styling and TODOs have now been removed. |
zlataovce
approved these changes
Mar 31, 2024
olijeffers0n
requested changes
Apr 2, 2024
Member
olijeffers0n
left a comment
olijeffers0n
left a comment
There was a problem hiding this comment.
First is the PR, Second is Prod. The Config Pages have changed slightly with respect to margins and highlight colours not being active.
Contributor
Author
|
Member
|
Looks generally good, I’ll review properly soon |
olijeffers0n
approved these changes
Apr 6, 2024
sowelipililimute
pushed a commit
to sowelipililimute/docs
that referenced
this pull request
Sep 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes all instances of inline styling. Ternary operator calls in
classNamehave been replaced with the clsx() helper method for improved readability.Only visual inconsistency should be the Icons that originally had 8 pixel margins and the slider markers in the script generator.